2013-12-28T00:07:32 *** Nazeo_Aelko_Neze is now known as Nazeo|Away 2013-12-28T01:07:45 *** Ibaraki_Ibuki has quit IRC 2013-12-28T02:38:40 *** Nazeo|Away is now known as Nazeo 2013-12-28T04:10:01 *** Nmlgc has quit IRC 2013-12-28T04:11:43 *** Nmlgc has joined #thcrap 2013-12-28T06:28:55 It's done! ... sort of. 2013-12-28T06:33:34 Yay- huh? 2013-12-28T06:39:12 Turns out that the 2 commits actually became 5 because I decided to move game title translations to the string table, and that required refactoring of the string table code to work out nicely, but then Jansson crashed because it didn't check for a NULL parameter (while it does so in pretty much every other function), so I fixed it and sent a pull request to the author. Maybe he'll accept that, maybe not, and if he doesn't, we have t 2013-12-28T06:40:13 We have accepted it? 2013-12-28T06:40:27 I don't know yet. 2013-12-28T06:40:46 Also, I decided to indeed update previously discovered third-party repositories that are not recursively reachable from the start repository. 2013-12-28T06:41:57 ... and I'm unsure about certain changes to the configuration tool. 2013-12-28T06:42:06 http://thpatch.net/wiki/File:thcrap-rc.zip 2013-12-28T06:42:07 <[Bot]MagicStone> Title: File:thcrap-rc.zip - Touhou Patch Center (at thpatch.net) 2013-12-28T06:42:15 So here's a release candidate for you to play around with. 2013-12-28T06:43:22 Whoo! 2013-12-28T06:43:43 "Warning: This file type may contain malicious code. By executing it, your system may be compromised." 2013-12-28T06:43:49 I always laughed at that message. 2013-12-28T06:45:09 ... OK, I'll add Authenticode signatures from the next build on :) 2013-12-28T06:45:43 :D 2013-12-28T06:46:20 So, if anything in the configuration tool is confusing to you, I did something wrong. 2013-12-28T06:46:44 Is the skip option present in there? 2013-12-28T06:47:16 Eh... Search for it? 2013-12-28T06:47:39 Like, remember how you skipped to the dialogs? 2013-12-28T06:48:16 Hint: It's not an option, it's a patch. 2013-12-28T06:48:24 Oh.. 2013-12-28T07:22:39 I suppose custom names is like macros in a sense? 2013-12-28T07:25:14 It's just for those people who want pretty names instead of a mere list of all their patches. That's also used for the shortcuts. 2013-12-28T07:26:26 It's because people will usually be running at least 4 patches (base_tsa, script_latin, western_name_order, lang_??). 2013-12-28T07:27:07 Ah... 2013-12-28T07:27:32 Listing all those in the shortcut would be too long. 2013-12-28T07:27:53 Uh oh 2013-12-28T07:28:04 Therefore, the automatically generated name ignores everything up until the first "lang_" patch. 2013-12-28T07:28:57 Submitted a bug in your db 2013-12-28T07:29:26 However, people might very well use other patches before that which they like to see represented. 2013-12-28T07:29:53 Like Touhou Online? 2013-12-28T07:32:16 If people just put, for example, aero or skipgame before their translation patches, these wouldn't be represented in the file name. 2013-12-28T07:32:33 Oh! 2013-12-28T07:32:36 Like that you mean. 2013-12-28T07:32:43 About that crash, could you add the log file? 2013-12-28T07:32:50 Sure could1 2013-12-28T07:32:53 *! 2013-12-28T07:36:33 (You are aware that you removed lang_en after adding it, right? :)) 2013-12-28T07:37:52 I... did? :x 2013-12-28T07:38:09 I didn't even realize I did that...! 2013-12-28T07:41:42 Does the crash happen if you run the configuration again and don't re-scan the game paths? 2013-12-28T07:42:03 Lemme try. 2013-12-28T07:43:07 Nope, works as intended 2013-12-28T07:54:31 http://thpatch.net/w/images/2/27/thcrap-rc.zip << OK, let's try again. 2013-12-28T07:54:45 Roger! 2013-12-28T07:55:08 Delete games.js before testing, just to be sure. 2013-12-28T07:55:18 Wilco. 2013-12-28T08:00:02 Hmm... 2013-12-28T08:00:24 Yes, it still crashes, but the log file should be more interesting now. 2013-12-28T08:00:36 It's been awhile since I used due to AIT- 2013-12-28T08:02:49 Blank file name 2013-12-28T08:03:10 Huh? 2013-12-28T08:03:24 Dropped it in db 2013-12-28T08:03:45 Blank file name = no patches :) 2013-12-28T08:03:57 Ah, I see! 2013-12-28T08:04:47 We probably should ask the user in that case. 2013-12-28T08:04:56 ? 2013-12-28T08:06:12 What I'm trying to figure out is this -> when it displays the patch stacking, does it ask for me to remove them when I place the corresponding number or to add them? :o 2013-12-28T08:07:52 I mean, it's perfectly possible to run thcrap with no patches. You only get the "AppLocale functionality" in that case. 2013-12-28T08:08:21 Oh, right, I wanted to reword that thing... 2013-12-28T08:09:44 Once you selected some patches, they are listed at the bottom of the screen. Entering the numbers there will remove them, entering more numbers from above adds more to that list. 2013-12-28T08:10:00 It doesn't make sense to add a patch more than once, after all. 2013-12-28T08:10:07 Mhm, true! 2013-12-28T08:10:42 So did it still crash? 2013-12-28T08:10:51 About to find out 2013-12-28T08:10:58 ( Sandbox unstable? ) 2013-12-28T08:11:35 Yes, but you can (and should) add it, there's nothing dangerous in it right now. 2013-12-28T08:11:42 Okay! 2013-12-28T08:13:20 Should it hang when I hit enter when it asks to scan? 2013-12-28T08:13:21 :o 2013-12-28T08:14:42 When it asks the (y/n) question? 2013-12-28T08:14:43 ( Also lol. It wants to run the game in my recycle bin ) 2013-12-28T08:14:46 Mhm 2013-12-28T08:15:09 ... no, of course not :( 2013-12-28T08:15:21 Okay, sending logs. 2013-12-28T08:15:32 ... but it apparently didn't hang? 2013-12-28T08:15:52 It did for a couple of secs. 2013-12-28T08:17:08 And it crashed at the end, right? 2013-12-28T08:17:17 Mhm 2013-12-28T08:19:11 OK, that crash should also happen if you don't rescan, can you confirm that? 2013-12-28T08:19:17 Wilco 2013-12-28T08:20:03 I noticed something 2013-12-28T08:20:12 Some features are packaged with others. 2013-12-28T08:20:42 And yes 2013-12-28T08:20:55 Stops working even when not scannig 2013-12-28T08:20:57 *scanning 2013-12-28T08:21:12 Yes. This is what we call "dependencies" and it is the second big feature of this build, next to advanced image patching. :) 2013-12-28T08:21:28 Whoo! 2013-12-28T08:21:33 It makes sense though. 2013-12-28T08:21:45 Western Name orders if using a langauge such as en or de. 2013-12-28T08:22:20 ... in fact, every language with Latin script except Hungarian, which is pretty much the sole reason why this is a separate patch. 2013-12-28T08:23:56 It's very important for third-party repositories because they most likely don't want to bundle their own copy of base_tsa. This way, they can directly pull in the one from thpatch. 2013-12-28T08:26:27 So... 2013-12-28T08:26:32 * Nazeo raises a hand. 2013-12-28T08:27:06 Yes? 2013-12-28T08:27:26 Let's say... 200 people pull translations at one time. Or even 2,000. And so on. How resource intensive would it be. It's just text files being transferred, right? 2013-12-28T08:27:34 So the footprint wouldn't be very large? 2013-12-28T08:28:10 Don't worry, two servers are more than enough to handle that. 2013-12-28T08:28:38 Hmm... 2013-12-28T08:29:16 Did the attacks on the server go away? 2013-12-28T08:29:31 The directory reversal one and such? 2013-12-28T08:31:17 Ah, that old stuff. That really wasn't a serious attack, just the usual bots that try such things on every page they can find. 2013-12-28T08:31:40 It was bots in the wild? 2013-12-28T08:31:43 Yep. 2013-12-28T08:32:21 Should the attack been successful, what would the damage been? 2013-12-28T08:37:12 Hmm. That one back then went straight for /etc/shadow, which would have given him password hashes for all accounts on the system if it had worked (which it didn't). 2013-12-28T08:37:31 Roger. 2013-12-28T08:37:45 That person then had familiarity with mediawiki 2013-12-28T08:38:05 It wasn't an attack on MediaWiki, but on the VPS directly. 2013-12-28T08:38:44 Oh wow... 2013-12-28T08:38:55 ( Also... don't mind those eyes .-. ) 2013-12-28T08:39:03 I don't think it makes a difference though. Really, you shouldn't worry. 2013-12-28T08:39:14 Nah, I know you have it handled 2013-12-28T08:40:17 Just buy a new server today, and you'll see dozens of bots trying to get into phpMyAdmin or Wordpress or similar software the next day. 2013-12-28T08:40:52 I only really picked that out back then because it made for a nice conspiracy theory, remember? 2013-12-28T08:40:53 aaaaa 2013-12-28T08:40:59 * Nazeo nods 2013-12-28T08:42:52 Hmm, could we do a TeamViewer session to look for that crash? 2013-12-28T08:43:00 Mhm! 2013-12-28T08:43:03 * Nazeo goes to download. 2013-12-28T08:47:45 Ok, we are up. 2013-12-28T09:09:06 Got it. Heh, a classic double-free. 2013-12-28T09:14:05 Oh hey, that's another bug that was reported ages ago and I had no clue what the problem was! 2013-12-28T09:32:32 Conclusion: Pretty much human error. 2013-12-28T09:32:51 That's okay :) 2013-12-28T09:33:41 Remember, don't extract thcrap into any game directory, or you will be thrust into the deepest levels of Hell. 2013-12-28T09:33:46 DLL Hell, that is. 2013-12-28T09:33:52 :o 2013-12-28T09:34:08 It's like SQL Hell 2013-12-28T09:34:10 But worse. 2013-12-28T09:37:49 Also I was wondering... 2013-12-28T09:37:53 But hey, at least we can improve that error message now. 2013-12-28T09:37:58 Yes? 2013-12-28T09:38:08 Thpatch should get some sort of splash page. 2013-12-28T09:38:31 Splash page? As in, when you start the configuration tool? 2013-12-28T09:38:42 I mean the wiki itself. 2013-12-28T09:38:46 http://gensoukyoueasternstory.net/splash-screen?back_uri= as an example. 2013-12-28T09:38:47 <[Bot]MagicStone> Title: Gensoukyou: Eastern Story (at gensoukyoueasternstory.net) 2013-12-28T09:40:27 Hmm, I'm not convinced. I mean, people only link the download page anyway. 2013-12-28T09:41:22 True... 2013-12-28T09:42:12 In the long run, I want to get rid of the wiki entirely, actually. 2013-12-28T09:42:19 Ah... 2013-12-28T09:42:27 What would be used instead? 2013-12-28T09:42:56 I don't know anything, so I'd probably have to write something myself. 2013-12-28T09:43:08 Whoa... 2013-12-28T09:43:25 That'll be a big project :o 2013-12-28T09:45:54 ... which, again, brings us to artwork. 2013-12-28T09:46:12 Rawr... artwork... 2013-12-28T10:58:42 Ah, reminds me I wanted to do a proof of concept of what I had in mind for artwork translations… 2013-12-28T10:58:59 And I won’t be able to before a few weeks at least. 2013-12-28T10:59:41 Btw I didn’t know it could replace applocale with no patch, this is a great feature for windows users. 2013-12-28T11:08:32 Basically, we need to replace the locale-bound *A functions of the Win32 API with UTF-8 wrappers around the UTF-16 *W functions to be able to print all of Unicode reliably on any system. 2013-12-28T11:09:08 If the conversion fails because input strings are not valid UTF-8, we just fall back to Shift-JIS. Ta-dah, AppLocale functionality. :) 2013-12-28T11:09:46 Ok. 2013-12-28T11:33:53 *** Nazeo has quit IRC 2013-12-28T12:13:34 *** zertap has quit IRC 2013-12-28T12:15:11 *** zertap has joined #thcrap 2013-12-28T12:41:51 *** KyoriAsh has quit IRC 2013-12-28T14:21:56 *** Nmlgc has quit IRC 2013-12-28T18:00:47 *** Kimmachinima has joined #thcrap 2013-12-28T18:28:40 *** albel727 has quit IRC 2013-12-28T18:36:06 *** albel727 has joined #thcrap 2013-12-28T18:44:12 *** JHeroGHJP has joined #thcrap 2013-12-28T22:28:46 *** Ibaraki_Ibuki has joined #thcrap 2013-12-28T22:50:41 *** JHeroGHJP has joined #thcrap